Skip to content

Port: fix type for SecurityGroupRefs#439

Merged
mandre merged 1 commit intok-orc:mainfrom
shiftstack:port-securitygroups-type
Apr 17, 2026
Merged

Port: fix type for SecurityGroupRefs#439
mandre merged 1 commit intok-orc:mainfrom
shiftstack:port-securitygroups-type

Conversation

@mandre
Copy link
Copy Markdown
Collaborator

@mandre mandre commented Jun 11, 2025

It should be a list of KubernetesNameRef and not OpenStackName.

Fixes #438

@mandre mandre force-pushed the port-securitygroups-type branch from de706fa to 50f2330 Compare June 11, 2025 05:59
@github-actions github-actions Bot added the semver:major Breaking change label Jun 11, 2025
@mandre mandre force-pushed the port-securitygroups-type branch from 50f2330 to 9ce168a Compare June 11, 2025 06:07
Copy link
Copy Markdown

@evrardjp-cagip evrardjp-cagip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually tested, but looks sane to me, so far.

I cannot promise I will be able to test it soon, so please merge with caution.

@mandre mandre added this to the Release 3.0 milestone Oct 19, 2025
@mandre mandre force-pushed the port-securitygroups-type branch from 9ce168a to f706947 Compare April 17, 2026 06:19
@mandre mandre enabled auto-merge April 17, 2026 06:20
@mandre mandre disabled auto-merge April 17, 2026 06:20
It should be a list of KubernetesNameRef and not OpenStackName.

Fixes k-orc#438
@mandre mandre force-pushed the port-securitygroups-type branch from f706947 to 5c24c4c Compare April 17, 2026 06:27
@mandre mandre added this pull request to the merge queue Apr 17, 2026
Merged via the queue into k-orc:main with commit 91edf1e Apr 17, 2026
10 checks passed
@mandre mandre deleted the port-securitygroups-type branch April 17, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:major Breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect doc for PortResourceSpec or incorrect implementation of the data structure?

2 participants