Draft
Conversation
Per Package Coveragemodelparserreport-viewerui-componentsPer File Coverage |
|
Member
Author
|
Goal: Coverage on new Code |
Member
|
Is this not something that could be done via Sonar? Or did you decide specifically against sonar-based coverage? |
Member
Author
|
I think it is easily possible to do this with sonar. The only disadvantage would be that sonarcloud and the unit tests would either need to be in the same action or sonarcloud needs to depend on the unit tests and thus only get executed when tests are successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR adds a test coverage report for the report-viewer.
The tests get executed for each package and then a script bundles them into a single report.
The action then posts a comment containing:
An HTML version of the report where a per line analysis can be seen is attached to the action run
If the line coverage falls below 20% the action fails
We should discuss whether the line coverage is what we want for this or whether we should use a different metric or even a composed one like sonarcloud does.
We should discuss if we want a simple message like the one below or put in the work to create a more styled one with colors for different values