Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
Currently, if a user explicitly passes
?num=0(or00, which happened to me when building a clock that hit the top of the minute/hour), the counter ignores the override and acts as a standard page-hit counter instead.This happens because the Zod schema defaults to
0, the route destructuring defaults to0, and thegetCountByNamefunction explicitly checksif (num > 0)to bypass the database. Because0is not greater than0, it falls through to the database increment logic.The Solution
This PR introduces
-1as the new default "empty" state, allowing the backend to differentiate between "the user didn't provide a number" and "the user explicitly wants to display zero."Changes Made:
minconstraint ofnumto-1and updated thedefaultto-1.numfrom0to-1in theapp.getroute.getCountByNamefromif (num > 0)toif (num >= 0).Testing & Impact
numis omitted) will now default to-1. Since-1is not>= 0, they will safely fall through to the standard database increment logic just like before.0or00images by passing?num=0.