[WIP] Enhance Hytale server management script with error handling and security

[Copilot]

Comprehensive Hytale Server Management Script Enhancements

Phase 1: Code Organization & Helper Functions

• Extract color/formatting definitions to top of file (centralize)
• Create helper functions for common patterns:
  • validate_port() - Port validation (1024-65535)
  • validate_disk_space() - Check available disk space
  • check_root_required() - Validate sudo/root access
  • print_progress() - Standardized progress output
  • confirm_action() - Interactive confirmation with timeout
  • sanitize_path() - Path sanitization for security
  • show_error() - Standardized error messages
  • check_dependencies() - Dependency validation

Phase 2: Security Enhancements

• Set strict permissions (600) for credential files
• Add path sanitization in all file operations
• Improve cron validation and sanitization
• Add file integrity checks for critical operations

Phase 3: Error Handling & Validation

• Add comprehensive port validation using helper
• Improve error messages for failed downloads
• Add root checks for systemd operations
• Better dependency checking with helpful messages
• Add disk space validation before critical operations

Phase 4: Bug Fixes

• Fix start_server timeout (extend from 30s to 60s)
• Fix race conditions in restore_server with proper waits
• Simplify cron time calculations in show_status
• Fix backup retention edge cases
• Add cleanup on script interruption (trap)

Phase 5: New Functionality

• Add restart command (graceful restart)
• Add edit-config command with validation
• Add rotate-logs command for log rotation
• Add backup integrity checking
• Add rollback capability for failed updates
• Add debug mode flag
• Enhance status with more system details

Phase 6: UX Improvements

• Add progress indicators for long operations
• Improve formatting of server details
• Better help with examples
• Color-coded status indicators
• Add timestamps to logging output
• Add dry-run mode for destructive operations
• Improve confirmation prompts

Phase 7: Additional Features

• Add systemd journal integration
• Add metrics collection (uptime, restarts)
• Add notification support for failures
• Add performance tuning recommendations
• Add hooks for extensibility (pre/post operations)

Original prompt

Improve the Hytale Server management script with the following comprehensive enhancements:

1. Error Handling & Validation

• Add comprehensive input validation for port ranges (1024-65535)
• Implement better error messages for failed downloads
• Check if running as root when needed (systemd operations)
• Add validation for disk space before critical operations
• Better handling of missing dependencies

2. Security Enhancements

• Set stricter file permissions (600) for auth/credentials files
• Validate downloaded files with checksums when available
• Add file integrity checks
• Sanitize file paths to prevent injection attacks
• Secure cron job management with better validation

3. Code Organization

• Break down oversized functions (install_server is 400+ lines)
• Extract common patterns into reusable helper functions
• Reduce code duplication between backup and safety backup logic
• Centralize color/formatting definitions
• Create separate module for cron management
• Improve function ordering and documentation

4. Functionality Improvements

• Add server restart command (graceful restart)
• Add configuration editor function with validation
• Implement log rotation functionality to prevent disk bloat
• Add rollback capability for failed updates
• Add backup integrity checking
• Add more detailed system information in status
• Support for multiple server instances
• Add debug mode for troubleshooting

5. Bug Fixes

• Fix start_server timeout (currently waits only 30 seconds for auth URL)
• Fix potential race conditions in restore_server with tmux sessions
• Simplify and fix cron time calculations in show_status
• Fix potential issues with special characters in paths
• Fix backup retention logic edge cases
• Ensure proper cleanup on script interruption

6. UX Improvements

• Add progress indicators for long operations
• Better formatting and structure of server details output
• Option to skip authentication on first start
• Show more helpful information when dependencies missing
• Add interactive menu with better navigation
• Add color-coded status indicators
• Better logging output with timestamps
• Add dry-run mode for destructive operations
• Add confirmation prompts with timeout for critical operations
• Improved help documentation with examples

7. Additional Features

• Add systemd journal integration for better logging
• Add metrics collection (uptime, restarts, backups)
• Add notification system for failed operations
• Add configuration backup and restore
• Add performance tuning recommendations
• Add server log archival functionality
• Add pre/post-operation hooks for extensibility

This pull request was created from Copilot chat.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.