feat(terminal): add clickable file path links#43
Closed
maskar wants to merge 0 commit intojohannesjo:mainfrom
Closed
feat(terminal): add clickable file path links#43maskar wants to merge 0 commit intojohannesjo:mainfrom
maskar wants to merge 0 commit intojohannesjo:mainfrom
Conversation
5 tasks
Owner
|
Very nice addition! Could you have a look at the conflicts? |
81d9da5 to
9ce6abe
Compare
Contributor
Author
|
Rebased on latest main, conflicts resolved. |
Owner
|
Thank you! Was closing this intentional? |
Contributor
Author
|
No, not intentional — the force push after rebasing may have caused GitHub to auto-close it. I can't reopen it (GitHub error). Want me to open a fresh PR from the same branch? |
Owner
|
Want me to open a fresh PR from the same branch? Yes, that would be great! Though I think I might have somehow merged this. Maybe together with one of the other PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File paths in terminal output are now highlighted and clickable. Clicking opens the file with the system default handler.
Supports:
/Users/foo/bar.ts./src/lib/theme.ts,../package.jsonsrc/components/Foo.tsx@xterm/xterm/typings/xterm.d.tssrc/App.tsx:42:10(stripped before opening)file.md.→file.md)Also adds an
onFileLinkcallback prop toTerminalViewfor parent components to handle specific file types differently.Test plan
:line:colsuffixes are recognized and opened correctly.,,,)) is not included in the link