fix: branch dropdown, diff base branch, and direct mode auto-checkout#34
Merged
johannesjo merged 2 commits intojohannesjo:mainfrom Mar 25, 2026
Merged
fix: branch dropdown, diff base branch, and direct mode auto-checkout#34johannesjo merged 2 commits intojohannesjo:mainfrom
johannesjo merged 2 commits intojohannesjo:mainfrom
Conversation
Three bug fixes for the task creation and diff review workflows: 1. Branch dropdown: merge two racing SolidJS createEffect blocks into one effect with loading spinner and retry+toast error handling (DROP-01, DROP-02) 2. Diff base branch: normalize empty-string baseBranch to undefined at the IPC boundary (register.ts), task creation (tasks.ts), and legacy state load (persistence.ts) so diffs use the correct per-task base branch instead of silently falling back to main (DIFF-01, DIFF-02, DIFF-03) 3. Direct mode auto-checkout: replace "Please checkout X first" warning with automatic git checkout when creating a Direct mode task on a non-current branch (CHECKOUT-01) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Thank you very much <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createEffectblocks into one. Added loading spinner and retry+toast error handling.maininstead of per-task base branch. Normalized empty-stringbaseBranchtoundefinedat the IPC boundary, task creation, and legacy state load.git checkoutwhen creating a Direct mode task on a non-current branch. Shows git's error message if checkout fails (e.g., dirty working tree).Test plan
develop— diff should show againstdevelop, notmainbaseBranch: ''— should auto-normalizenpm run typecheckpassesnpx vitest run— all 73 tests pass🤖 Generated with Claude Code