add global variable to configure datasets directory#72
Open
KoRiF wants to merge 1 commit intojoaopauloschuler:masterfrom
Open
add global variable to configure datasets directory#72KoRiF wants to merge 1 commit intojoaopauloschuler:masterfrom
KoRiF wants to merge 1 commit intojoaopauloschuler:masterfrom
Conversation
Owner
|
The main idea is good. It's against my religion to have global variables. So, I'll implement your solution passing parameters. |
Author
|
in the place where the dataset is loaded, the religion is procedural
programming style
in a situation where there are no classes, using a global variable is
not a religious crime.
I mean, the module is called "neural dataset", and if it were a class,
then the directory with the dataset could well be its field
i.e. this global variable really defines the context, and is not a
parameter of each new call to the algorithm
therefore, probably, your gods would forgive us this sin
2021-10-27 16:32 GMT+03:00, joaopauloschuler ***@***.***>:
… The main idea is good. It's against my religion to have global variables.
So, I'll implement your solution passing parameters.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#72 (comment)
|
Owner
|
The request is valid and I'm still considering it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows to load CIFAR10 & CIFAR100 datasets from the arbitrary location
by default, directory initialized as empty string, so this should not affects on the existing logic
usage:
`
...
uses neuraldatasets; //usual import
//initialization
neuraldatasets.directory := '..\..\Data\cifar-10-batches-bin'; // path to CIFAR-10* //including trailing path delimiter
`