replace got http client with Fetch API#28
Open
keturn wants to merge 9 commits intojmerle:masterfrom
Open
Conversation
was v16. tar requires >= 18 but might as well go up to current LTS while we're here.
no changes required (aside from updating to node >= 20, already done)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
got probably still works fine, but it is 300 kB.
The errors I was chasing down weren't actually from this source in the end, but having already done the work of switching, it seems worth committing.
got's successor, ky doesn't exactly support streaming downloads, so I went with straight
fetchfor the big file. That means missing out on some ky features like auto-retries, but I'm okay with that.Branch based on #24, look there first.