Skip to content

cleanup of xray ignore rules functionality and added get all by filter implementation#979

Open
3choBoomer wants to merge 2 commits intojfrog:dev-deprecated-please-target-master-directlyfrom
3choBoomer:enhance-xray-ignore-rules-support
Open

cleanup of xray ignore rules functionality and added get all by filter implementation#979
3choBoomer wants to merge 2 commits intojfrog:dev-deprecated-please-target-master-directlyfrom
3choBoomer:enhance-xray-ignore-rules-support

Conversation

@3choBoomer
Copy link
Copy Markdown

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Moving some functionality from #960
cleaning up some stuff from #967

  • Fixed issues with inline docs
  • Added minimum server version checks
  • revised return values to follow golang standards
  • revised return value of Get method to match documentation.
  • Implemented get all by filters functionality.

@3choBoomer
Copy link
Copy Markdown
Author

@3choBoomer 3choBoomer mentioned this pull request Jul 22, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants