fix: tolerate node_modules path differences in lib/ verification#34
Open
sverdlov93 wants to merge 1 commit intomainfrom
Open
fix: tolerate node_modules path differences in lib/ verification#34sverdlov93 wants to merge 1 commit intomainfrom
sverdlov93 wants to merge 1 commit intomainfrom
Conversation
Without a lockfile, npm may hoist transitive dependencies differently across environments. esbuild embeds node_modules paths as comments and __commonJS keys in the bundle, causing the byte-for-byte lib/ check to fail even when the actual code is identical. Use `git diff -I 'node_modules/'` to ignore hunks where every changed line is a node_modules path annotation, while still catching real source drift.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-lock.json, npm may hoist transitive dependencies differently across environments. esbuild embeds thesenode_modulespaths as comments and__commonJSkeys in the bundle, causing the byte-for-bytelib/verification step to fail even when the actual code is functionally identical.git status --porcelainwithgit diff -I 'node_modules/', which ignores hunks where every changed line is anode_modulespath annotation, while still catching real source drift.git ls-files --otherscheck to preserve detection of untracked files inlib/.Test plan
src/without rebuildinglib/still fails the check