Improve logging messages for better debugging in email sending failures#1534
Improve logging messages for better debugging in email sending failures#1534Vaibhav34-2006 wants to merge 11 commits intojenkinsci:mainfrom
Conversation
Adds a documentation note to recipes clarifying ${FILE} token behavior
when the referenced workspace file is missing, along with best practices.
Docs: clarify ${FILE} token behavior in recipes
|
Hlw @Vaibhav34-2006 I noticed that there’s an extra quote at the end of two log messages, "Email sending failed due to invalid or rejected recipient addresses. Verify email formats and permissions."" These trailing quotes would end up in the actual log output, and it might make things a bit confusing while debugging. Can you please remove them? |
|
Just a quick note this PR has 10 commits for what seems like a fairly small change. It might be a good idea to squash them into 1 or 2 more meaningful commits before merging, just to keep the git history nice and clean. You can easily do that with git rebase -i. |
|
I noticed the PR description mentions testing was done with mvn clean install -DskipTests, which skips the test suite. Could you also run mvn test and confirm that all tests pass? It’d be great to make sure nothing unexpected was affected. |
|
Hi, I also noticed an incorrect log message in the Please let me know if you'd prefer this to be in a separate PR. |
|
Hey @Vaibhav34-2006, thanks for the quick fix Including it in the same PR makes sense since it’s related to the same logging improvements. Everything looks good to me.. |
This PR improves logging messages in email sending failure scenarios to provide more clarity for debugging.
Changes:
These changes do not modify any logic and are intended to improve observability and troubleshooting.
Testing:
mvn clean install -DskipTestsmvn spotless:applyThank you!