Russo_ex4#13
Open
Ross10 wants to merge 8 commits intojce-il:masterfrom
Ross10:master
Open
Conversation
Contributor
|
it seems to me that your methods (like map inconsistencies) missed the point if im not mistaken you just returned true or false, with no relation to the actual map inconsistencies... |
Author
|
היי איתמר, ראיתי עכשיו ששלחת שזה לא היה כפי שרציתם.. אני רוצה לתקן האם זה אפשרי ? ואם כן, אז אם אפשר להגיש לך עד יום שני כי אני טס היום בערב ולא אספיק לעשות את זה עוד היום...תודה וסופ"ש מהנה :) it seems to me that your methods (like map inconsistencies) missed the pointif im not mistaken you just returned true or false, with no relation to the actual map inconsistencies... — |
Contributor
|
just add the missing parts and commit than pull request and tag me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my ex4