Rename for consistency with Jakarta Data#992
Open
njr-11 wants to merge 2 commits intojakartaee:mainfrom
Open
Conversation
njr-11
force-pushed
the
991-query-anno-name-consistency-with-jakarta-data
branch
from
1eb2e9c to
77737f2
Compare
Member
Author
|
Resolve merge conflicts and switch from the placeholder name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step toward resolving #991
We know that we want to rename
StaticNativeQuerytoNativeQueryStaticQueryto{???}QueryStaticQueryOptionsto justQueryOptions.This PR covers items 1 and 3, while using
PersistenceQueryas a placeholder for item 2 (it accepts Jakarta Persistence Query Language) which can later be switched to something else once there is agreement on a name. Hopefully the temporary step will not be objectionable. This will allow Jakarta Data to fully update its references to items 1 and 3, with only changes to the name for item 2 pending.