feat: add native function to check protocol feature flags in Move#11443
Merged
feat: add native function to check protocol feature flags in Move#11443
Conversation
iota-ci
added
sc-platform
miker83z
approved these changes
May 7, 2026
fix(iota-json-rpc-tests): fix get_normalized_move_modules_by_package
valeriyr
force-pushed
the
vm-lang/protocol-feature-flags-in-move
branch
from
7c52d4f to
630c871
Compare
miker83z
approved these changes
May 8, 2026
lollobene
reviewed
May 8, 2026
| let is_enabled = match String::from_utf8(bytes.to_vec()) { | ||
| Ok(s) => { | ||
| // Use the auto-generated lookup_feature method to find the feature flag | ||
| match protocol_config.lookup_feature(s) { |
Contributor
There was a problem hiding this comment.
Just pointing out that lookup_feature only looks for boolean feature flags and filters out other flags, is this intended?
Contributor
Author
There was a problem hiding this comment.
Yes, it is added to check feature flags only. feature_flags contains only boolean values.
lollobene
approved these changes
May 8, 2026
kodemartin
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Add iota::protocol_config::is_feature_enabled() to allow Move code to query protocol feature flags at runtime.
This enables conditional logic and fallbacks based on protocol version capabilities.
Links to any relevant issues
fixes #11465