chore: remove iota-benchmark and iota-surfer#11428
Draft
muXxer wants to merge 2 commits intoremove/aws-orchestratorfrom
Draft
chore: remove iota-benchmark and iota-surfer#11428muXxer wants to merge 2 commits intoremove/aws-orchestratorfrom
iota-benchmark and iota-surfer#11428muXxer wants to merge 2 commits intoremove/aws-orchestratorfrom
Conversation
github-actions
Bot
added
documentation
muXxer
commented
May 5, 2026
| } | ||
|
|
||
| #[test] | ||
| async fn test_iota_operations_config() { |
Contributor
Author
There was a problem hiding this comment.
Hello reviewers!
There is no iota-operation repo, and the code paths of this test are all covered elsewhere:
IotaKeyPair::decode / encode roundtrip: covered by test_private_keys_import_export, which roundtrips bech32 ↔ hex ↔ base64 against three known test vectors and asserts the derived address — a stronger check than test_iota_operations_config.
FileBasedKeystore::new write/read: exercised by ~10 tests in crates/iota-keys/tests/tests.rs (write a key, reopen, assert content survives), plus the error-path is covered by test_load_keystore_err
Contributor
|
✅ Vercel Preview Deployment is ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[run-ci]
Description of change
This PR removes the two crates from the mono-repository.
Should be merged after #11422
How the change has been tested