feat(consensus): regression test for StarfishSpeed phantom-ack invariant#11403
Open
VorobyevIlya wants to merge 4 commits intoconsensus/feat/starfish-speedfrom
Open
feat(consensus): regression test for StarfishSpeed phantom-ack invariant#11403VorobyevIlya wants to merge 4 commits intoconsensus/feat/starfish-speedfrom
VorobyevIlya wants to merge 4 commits intoconsensus/feat/starfish-speedfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Adds a failing test that catches a safety-invariant violation in StarfishSpeed Optimistic commit: strong-vote bytes computed against one leader get credited as phantom acks for a different canonical leader after a schedule rotation, leading to transactions being committed without 2f+1 stake actually having their data. Also extracts
Core::compute_strong_vote_foras apub(crate)static helper so the test drives bytes through production code rather than fixtures.How the change has been tested