Skip to content

feat(consensus): regression test for StarfishSpeed phantom-ack invariant#11403

Open
VorobyevIlya wants to merge 4 commits intoconsensus/feat/starfish-speedfrom
consensus/test/swap-table-mismatch-bug
Open

feat(consensus): regression test for StarfishSpeed phantom-ack invariant#11403
VorobyevIlya wants to merge 4 commits intoconsensus/feat/starfish-speedfrom
consensus/test/swap-table-mismatch-bug

Conversation

@VorobyevIlya
Copy link
Copy Markdown
Contributor

@VorobyevIlya VorobyevIlya commented May 1, 2026

Description of change

Adds a failing test that catches a safety-invariant violation in StarfishSpeed Optimistic commit: strong-vote bytes computed against one leader get credited as phantom acks for a different canonical leader after a schedule rotation, leading to transactions being committed without 2f+1 stake actually having their data. Also extracts Core::compute_strong_vote_for as a pub(crate) static helper so the test drives bytes through production code rather than fixtures.

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@iota-ci iota-ci added consensus Issues related to the Core Consensus team core-protocol labels May 1, 2026
@VorobyevIlya VorobyevIlya self-assigned this May 1, 2026
@VorobyevIlya VorobyevIlya marked this pull request as ready for review May 1, 2026 12:19
@VorobyevIlya VorobyevIlya requested a review from a team as a code owner May 1, 2026 12:19
@VorobyevIlya VorobyevIlya requested review from polinikita and removed request for a team May 1, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consensus Issues related to the Core Consensus team core-protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants