fix(wallet): approval popup crash on network mismatch#11058
Merged
fix(wallet): approval popup crash on network mismatch#11058
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…net-work-mismatch
brancoder
requested changes
Apr 1, 2026
Contributor
brancoder
left a comment
brancoder
left a comment
There was a problem hiding this comment.
we could update the useTransactionDryRun queryKey to contain sender and chain: queryKey: ['dryRunTransaction', sender, chain, transaction.getData()], wdyt?
…net-work-mismatch
…net-work-mismatch
marc2332
approved these changes
Apr 1, 2026
msarcev
approved these changes
Apr 1, 2026
brancoder
approved these changes
Apr 1, 2026
brancoder
deleted the
tooling-wallet/fix-wallet-approval-crash-net-work-mismatch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context here
When the dashboard is on
testnetand the wallet is ondevnet,the transaction approval popup crashed because
useTransactionDatawas trying to look up testnet objects on devnet — and those don't exist there.
Changes
useTransactionDatafrom the approval flow — it was redundantand caused the crash by ignoring the dapp's network (
chainparam)useTransactionDryRun— already supports thechainparameterand provides the same loading/error states
transaction.getData()for the details tab — no RPC call needed,data is already available in the transaction object