feat(wallet): fix auto-expand wallet when wallet indexes have gaps#11045
Merged
feat(wallet): fix auto-expand wallet when wallet indexes have gaps#11045
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
KeitoTadashi
approved these changes
Apr 9, 2026
brancoder
requested changes
Apr 10, 2026
Contributor
brancoder
left a comment
brancoder
left a comment
There was a problem hiding this comment.
LG we just need to enable this for seed derived accounts also
| type: accountsFormType, | ||
| }); | ||
| const newAccount = accountCreationResult?.[0]; | ||
| if (newAccount && isMnemonicSerializedUiAccount(newAccount)) { |
Contributor
There was a problem hiding this comment.
we should add the Seed accounts check here and do this for that type also
if (newAccount && (isMnemonicSerializedUiAccount(newAccount) || isSeedSerializedUiAccount(newAccount)))
the reason being that the legacy account can come from a ff seed (check isLegacyAccount)
seed example: 0xa5cfd040906b2761cb2ebd9e7c7bba9b0c125e6123aa51a4b49d901254b6ac4659ac0e36ff9f4c2062d8f67dec435dd019826962170eb4889ba15eada3128639
brancoder
approved these changes
Apr 10, 2026
begonaalvarezd
pushed a commit
that referenced
this pull request
Apr 10, 2026
…11045) # Description of change [Screencast from 2026-03-31 09-24-31.webm](https://github.com/user-attachments/assets/a1533866-d338-47be-9dd8-b6c8162a66eb) ## Links to any relevant issues fixes #8629 ## How the change has been tested Describe the tests that you ran to verify your changes. Make sure to provide instructions for the maintainer as well as any relevant configurations. --------- Co-authored-by: Marc Espin <[email protected]> Co-authored-by: Branko <[email protected]> Co-authored-by: Bran <[email protected]>
marc2332
pushed a commit
that referenced
this pull request
Apr 21, 2026
…11045) Co-Authored-By: Eva Vírseda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Screencast.from.2026-03-31.09-24-31.webm
Links to any relevant issues
fixes #8629
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.