feat(iota-sdk-types): derive Hash on Transaction / TransactionV1#1131
Merged
thibault-martinez merged 1 commit intodevelopfrom May 8, 2026
Merged
feat(iota-sdk-types): derive Hash on Transaction / TransactionV1#1131thibault-martinez merged 1 commit intodevelopfrom
thibault-martinez merged 1 commit intodevelopfrom
Conversation
563bf68 to
7f105fc
Compare
f2c25e4 to
b96e853
Compare
thibault-martinez
approved these changes
May 8, 2026
b96e853 to
bae8702
Compare
DaughterOfMars
approved these changes
May 8, 2026
* feat(iota-sdk-types): Transaction changes * remove custom rename * rename to UnchangedSharedKind
bae8702 to
7fa18bc
Compare
Alex6323
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the SDK replacement series, stacked on top of
sdk-replacement/27-TransactionKind.HashonTransactionandTransactionV1in crates/iota-sdk-types/src/transaction/mod.rs. Required by the monorepo replacement, whereiota-types::transaction::TransactionDataderivesHash.Transaction::V1in crates/iota-sdk-types/src/transaction/mod.rs: the#[serde(rename = "1")]is removed, so JSON now emits{"V1": …}instead of{"1": …}. BCS is unchanged.UnchangedSharedKindin crates/iota-sdk-types/src/effects/v1.rs: the binary helperBinaryUnchangedSharedKindgains#[serde(rename = "UnchangedSharedKind")]so generated schemas keep the public type name.