Skip to content

feat(iota-sdk-types): derive Hash on Transaction / TransactionV1#1131

Merged
thibault-martinez merged 1 commit intodevelopfrom
sdk-replacement/28-TransactionData
May 8, 2026
Merged

feat(iota-sdk-types): derive Hash on Transaction / TransactionV1#1131
thibault-martinez merged 1 commit intodevelopfrom
sdk-replacement/28-TransactionData

Conversation

@Thoralf-M
Copy link
Copy Markdown
Member

@Thoralf-M Thoralf-M commented May 7, 2026

Summary

Continues the SDK replacement series, stacked on top of sdk-replacement/27-TransactionKind.

  • Derive Hash on Transaction and TransactionV1 in crates/iota-sdk-types/src/transaction/mod.rs. Required by the monorepo replacement, where iota-types::transaction::TransactionData derives Hash.
  • Drop the JSON-only variant rename on Transaction::V1 in crates/iota-sdk-types/src/transaction/mod.rs: the #[serde(rename = "1")] is removed, so JSON now emits {"V1": …} instead of {"1": …}. BCS is unchanged.
  • Pin the public schema name for UnchangedSharedKind in crates/iota-sdk-types/src/effects/v1.rs: the binary helper BinaryUnchangedSharedKind gains #[serde(rename = "UnchangedSharedKind")] so generated schemas keep the public type name.

@Thoralf-M Thoralf-M changed the title feat(iota-sdk-types): Transaction changes (#1051) feat(iota-sdk-types): derive Hash on Transaction / TransactionV1 May 7, 2026
@Alex6323 Alex6323 force-pushed the sdk-replacement/27-TransactionKind branch from 563bf68 to 7f105fc Compare May 8, 2026 07:02
@Thoralf-M Thoralf-M marked this pull request as ready for review May 8, 2026 07:27
@Thoralf-M Thoralf-M requested a review from a team as a code owner May 8, 2026 07:27
@Thoralf-M Thoralf-M force-pushed the sdk-replacement/28-TransactionData branch from f2c25e4 to b96e853 Compare May 8, 2026 07:32
@Thoralf-M Thoralf-M force-pushed the sdk-replacement/28-TransactionData branch from b96e853 to bae8702 Compare May 8, 2026 07:50
Base automatically changed from sdk-replacement/27-TransactionKind to develop May 8, 2026 11:33
* feat(iota-sdk-types): Transaction changes

* remove custom rename

* rename to UnchangedSharedKind
@Thoralf-M Thoralf-M force-pushed the sdk-replacement/28-TransactionData branch from bae8702 to 7fa18bc Compare May 8, 2026 11:34
@thibault-martinez thibault-martinez merged commit 5cef1c9 into develop May 8, 2026
20 checks passed
@thibault-martinez thibault-martinez deleted the sdk-replacement/28-TransactionData branch May 8, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants