Open
Conversation
|
ou guys should really merge this one in, as it fixes those issues with more current versions of PHP. |
Contributor
|
+1 Please merge this! Otherwise getting these warnings in PHP 8.4: |
|
@sujitharamadass , I wonder if it is possible to merge this PR and release a new version? |
|
The pull request has been tested and is ready to be merged. It will be included in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents deprecations warnings such the following occurring when running on php 8.4
This change requires php 7.1, but given that there is a requirement on
guzzlehttp/guzzleversion^7.9this implies a minimum version of php 7.2.5 which I have replicated incomposer.jsonto make it clearer