fix: removeNullProperties should not filter out regular arrays#420
Open
mgkimsal wants to merge 1 commit intointuit:masterfrom
Open
fix: removeNullProperties should not filter out regular arrays#420mgkimsal wants to merge 1 commit intointuit:masterfrom
mgkimsal wants to merge 1 commit intointuit:masterfrom
Conversation
Existing removeNullProperties filtered out standard arrays, causing problems. Specifically, an $invoice object with $customerRef on it (with $customerRef['value']) was filtered out, causing "CustomerRef is missing" validation errors. I added the count() check to ignore empty array values, which seems in spirit with the 'removeNull' intention. Adding a test, based on the previously added testThatRemoveNullPropertiesLeavesNonNullValuesInPlace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing removeNullProperties filtered out standard arrays, causing problems. Specifically, an $invoice object with $customerRef on it (with $customerRef['value']) was filtered out, causing "CustomerRef is missing" validation errors.
I added the count() check to ignore empty array values, which seems in spirit with the 'removeNull' intention.
Adding a test, based on the previously added testThatRemoveNullPropertiesLeavesNonNullValuesInPlace