Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I reprocessed a database of ~1000 SIFT features per node with version 0.24 (this PR) and version 0.23. Here the comparison of the database size on disk (
ls -lh), which results in a ~15% reduction:0.23.0: 130 MB (zipped = 103MB)0.24.0: 111 MBDetails:

However, compressing the features has some CPU cost. On a desktop computer, it requires between 6 and 9 ms to compress up to 1000 SIFT features with keypoints and points3D.
Here some logs showing saving/loading features time from the database:
On
0.23.0, the corresponding logs:The loading time from the database is pretty much the same between the two versions (1.404 ms vs 1.401 ms for this case), but saving the features to the database takes significantly more time (9.391 ms vs 0.031 ms for this case). Based on the logs, most time spent is in zlib library, so not sure if that can be improved. One thing to note is that features are saved to database asynchronously while rtabmap is waiting for a new image, so in theory it doesn't add latency.
EDIT: a comparison with binary descriptors (GFTT/BRIEF)
0.24.057 MB (5% reduction):0.23.060 MB:Comparing the timing results in this case is interesting: the loading time is faster with compressed features but saving time is slower, with the same order of magnitude in both cases.
TODO: