[SYCL] resolve double free in CleanupSYCLMetadataFromLLVMUsed Pass#22016
Merged
KornevNikita merged 1 commit intoMay 18, 2026
Conversation
Previous implementation gathered all operands from @llvm.used list and destroyed every one by one. This patch considers the case when the list contains one variable more than once. fixes: CMPLRLLVM-75178
Contributor
|
/run |
Contributor
Author
|
@intel/llvm-gatekeepers Could we, please, merge that? |
Contributor
|
test failure: #22028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial implementation gathered all operands from @llvm.used list and destroyed every value one by one. This patch considers the case when the list contains one value more than once.
Side change: register "remove-device-global-from-llvm-compiler-used" pass to allow testing using "opt" tool.
fixes: CMPLRLLVM-75178