Merged
Conversation
as it will now operate on a list + rename "package" input arg to "packages"
223ab07 to
6a021ce
Compare
6a021ce to
f56e446
Compare
f56e446 to
cf9c5ea
Compare
cf9c5ea to
79e1c94
Compare
So they are more easy to read and navigate
Instead of doing it one by one using a matrix.
…e `unstable-release` depends on them
79e1c94 to
fb386eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes reworks the publication of rust crates to leverage the new ability of cargo to works on multiple crates at once.
Currently our publish have huge limitations which hurt our ability to deliver crates with correct dependencies to crates.io :
>=x.y.zas a stopgap, but this means that a publishedmithril-clientcan be seen as compatible with an oldermithril-commoneven if they are not.Those limitations are mostly due to the fact that we are publishing the crates one at a time, meaning that if crates
Bdepends on a updated version ofA, versions which is not yet published (likely because running publish in dry-run for the CI), theThe idea behind the introduction of the publish test in the CI was to protect ourselves against unpublished dependency graphs when releasing a new version. E.G., if crates
Awas already published but we want to publish a new version which introduce a dependency against a crateBwe want this CI job to fail ifBwas not taken into account for the publication.This PR removes those limitations by running
cargo publish, dry run or not, on all crates that needs it at once. This means that nowcargo publishis able to verify that the whole sets of crates to publish is coherent, solving our issues.Pre-submit checklist
Issue(s)
Closes #3230