feat: recently added assets page#28272
Conversation
| return withBoundingBox(withBoundingCircle, bbox); | ||
| }) | ||
| .where(truncatedDate(), '=', timeBucket.replace(/^[+-]/, '')) | ||
| .where(truncatedDate(options.orderingDate), '=', timeBucket.replace(/^[+-]/, '')) |
There was a problem hiding this comment.
Otherwise we would always be grouping assets into buckets by localDateTime. If I getBucket on the recently added page I should see assets with a matching createdBy in that bucket to match how getBuckets is grouping them.
danieldietzler
left a comment
danieldietzler
left a comment
There was a problem hiding this comment.
The code looks pretty good already, great job!
shenlong-tanwen
left a comment
shenlong-tanwen
left a comment
There was a problem hiding this comment.
The mobile changes looks really good to me
shenlong-tanwen
left a comment
shenlong-tanwen
left a comment
There was a problem hiding this comment.
The mobile changes LGTM!
|
📱 Android release APK (universal) — Download: https://github.com/immich-app/immich/actions/runs/25694859400/artifacts/6929137109 QR codeInstalls as a separate app (applicationId |
danieldietzler
left a comment
danieldietzler
left a comment
There was a problem hiding this comment.
The code looks good to me!
5 participants
Description
Adds a page to view assets in the order they were uploaded to Immich rather than sorting by when the photo/video was taken. The
/recently-addedpage is accessible through a new "Recently added" section in the Explore tab on web, and through the Search tab on mobile.How Has This Been Tested?
/recently-addedare ordered bycreatedAt/photosare still ordered bylocalDateTimeScreenshots (if appropriate)
Web
Mobile
API Changes
GET /timeline/bucketsandGET /timeline/bucketaccept an optionalorderByparameter to specify how assets should be grouped and sorted,localfor date taken (default) orcreatedfor date uploadedGET /timeline/bucketreturnscreatedAt, an array of upload dates per each asset in the bucketSyncAssetV1andSyncAssetV2include acreatedBypropertyChecklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
None.