Skip to content

Fix: Sync ReviewActivity theme with app dark mode (#18)#44

Open
harshagarwal4761 wants to merge 2 commits intoiiitl:masterfrom
harshagarwal4761:fix-review-theme
Open

Fix: Sync ReviewActivity theme with app dark mode (#18)#44
harshagarwal4761 wants to merge 2 commits intoiiitl:masterfrom
harshagarwal4761:fix-review-theme

Conversation

@harshagarwal4761
Copy link
Copy Markdown

@harshagarwal4761 harshagarwal4761 commented Apr 11, 2026

Resolves #18 .

Description

What is the purpose of this pull request?
Fixed issue#18 now the review section theme is synced with the whole app.

How it was fixed?
I updated activity_review.xml to use the app's existing custom theme variables.
Replaced the static background colors with @color/nav_black.
Replaced the static text colors with @color/nav_element.

Live Demo (if any)

proof

Checkout

  • I have read all the contributor guidelines for the repo.

Summary by CodeRabbit

  • Style
    • Updated the Review screen color scheme: backgrounds and cards now use the darker navigation background, and text/icons use the new navigation element color for improved contrast and consistency.
    • Cleaned up layout XML by removing obsolete comment blocks (no functional UI changes).

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 57fd7e8f-0fd1-436d-9c87-01178ef84fb0

📥 Commits

Reviewing files that changed from the base of the PR and between 17b9ff0 and 1328a59.

📒 Files selected for processing (1)
  • app/src/main/res/layout/activity_review.xml
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/src/main/res/layout/activity_review.xml

Walkthrough

Updated color references in the review activity layout to use navigation-themed dark palette colors; no structural or functional changes were made.

Changes

Cohort / File(s) Summary
Layout — Review Activity
app/src/main/res/layout/activity_review.xml
Replaced background colors (@color/bg, ?attr/colorSurface) with @color/nav_black; updated text/icon colors from @color/black and theme attributes (e.g., ?android:attr/textColorPrimary) to @color/nav_element; removed XML comment blocks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Fix toolbar issue #37: Modifies the same activity_review.xml file, though for toolbar/layout structural changes rather than color updates.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: syncing ReviewActivity theme with app dark mode, which matches the core objective of issue #18.
Linked Issues check ✅ Passed The PR successfully addresses issue #18 by replacing hard-coded colors with theme-aware color resources (@color/nav_black, @color/nav_element) to sync the ReviewActivity with app-wide Dark/Light theme.
Out of Scope Changes check ✅ Passed All changes are scoped to activity_review.xml layout file and directly address theme synchronization requirements without introducing unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/src/main/res/layout/activity_review.xml`:
- Around line 181-182: The hint and entered text currently use the same color
via the attributes android:textColorHint and android:textColor, remove the
visual parity by assigning a distinct, lighter hint color to
android:textColorHint (e.g., switch android:textColorHint to a new or existing
resource like `@color/nav_element_hint` or `@color/nav_element_secondary`) while
leaving android:textColor set to `@color/nav_element`; if the new resource doesn't
exist, add a corresponding color entry (nav_element_hint) in colors.xml with a
lighter/less prominent value.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a68d4767-6a50-4018-89b7-053fc8338a34

📥 Commits

Reviewing files that changed from the base of the PR and between e9da1c5 and 17b9ff0.

📒 Files selected for processing (1)
  • app/src/main/res/layout/activity_review.xml

Comment thread app/src/main/res/layout/activity_review.xml Outdated
@harshagarwal4761
Copy link
Copy Markdown
Author

@Pratikkp-code

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix]: Applying the Dark/Light theme in the Write Review section.

1 participant