chore: .npmrc security tweaks#10853
Draft
holloway wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this shouldn't be merged yet, it needs testing and more discussion.
chore
We use
npmandyarnand there some flags that might help with supply chain security.min-release-age: gives community time to flag malicious publishes,allow-git: don't allow dependencies fromgithub:user/repo,git+ssh://,git+https; instead preferring NPM which is more scrutinised,ignore-scripts: don't run preinstall/postinstall scripts as this is a common mechanism for compromised packages. So we should only enable if needed./.yarnrc.ymlYarn supports
ignore-scriptsandyarn buildandyarn legacy:buildwork so it seems we can enable this.Yarn 3.2.2 doesn't support
min-release-ageorallow-gitthose were added in 4.10.0./playwright/.npmrcCurrently this uses Node 16 / NPM 8.
ignore-scriptsis supported, but we'd need to upgrade to usemin-release-ageandallow-git.ignore-scripts: I'd guess that Chrome binaries are installed in a preinstall/postinstall script so this flag might break something./dev/coverage-action/.npmrcCurrently this uses Node 16 / NPM 8.
ignore-scriptsis supported, but we'd need to upgrade to usemin-release-ageandallow-git.No testing done yet.
/dev/deploy-to-container/.npmrcCurrently this uses Node 16 / NPM 8.
ignore-scriptsis supported, but we'd need to upgrade to usemin-release-ageandallow-git.No testing done yet.
/dev/k8s-get-deploy-name/.npmrcCurrently this uses Node 16 / NPM 8.
ignore-scriptsis supported, but we'd need to upgrade to usemin-release-ageandallow-git.No testing done yet.