fix: avoid PosixPath.endswith() in run_yang_model_checks_task#10819
Merged
jennifer-richards merged 1 commit intoMay 14, 2026
Merged
Conversation
Fixes ietf-tools#10818 Signed-off-by: SAY-5 <[email protected]>
jennifer-richards
approved these changes
May 14, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10819 +/- ##
=======================================
Coverage 88.48% 88.49%
=======================================
Files 332 332
Lines 44838 44836 -2
=======================================
Hits 39676 39676
+ Misses 5162 5160 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10818.
populate_yang_model_dirswas calling.endswith("/")onmoddir, which is apathlib.Path(not astr), causing the dailyrun_yang_model_checks_taskto fail withAttributeError("'PosixPath' object has no attribute 'endswith'"). Pass anf"{moddir}/"source directly to rsync so the trailing slash is always present and drop the brokenifblock.