Conversation
| } | ||
|
|
||
| luaRCPath := filepath.Join(configDir, ".luarc.json") | ||
| created, err := ensureLuaRC(luaRCPath, dest) |
There was a problem hiding this comment.
i already made my own .luarc.json before, and running --install-lua-types gives below:
resulting in ~/.config/jjui/.luarc.json exists but does not include ~/.config/jjui/types.lua
im thinking this is because of this line here. although i don't imagine most user probably don't have an existing one (and probably .luarc.json won't be updated often), for those who do like me, this skip on .luarc.json cuases workspace.library to not be updated
There was a problem hiding this comment.
Yes, I thought we shouldn't touch the file if the user has already put something in place as they are very like to be power users and know what they are doing.
cmd/genactions/main.go
Outdated
| b.WriteString("\n") | ||
|
|
||
| // Generate action classes for each owner | ||
| for _, owner := range allOwners { |
There was a problem hiding this comment.
Thanks! Good catch! I'll have a look at this.
I had implemented this a couple of weeks ago and then did a refactor of the code generator then rebased this on top of the latest changes. I assumed all is good because there was no conflict but seems like some things might be out of sync now.
cmd/genactions/main.go
Outdated
|
|
||
| ---Copy text to the system clipboard | ||
| ---@param text string Text to copy | ||
| function copy_to_clipboard(text) end |
There was a problem hiding this comment.
i think this function returns something like bool, string
jjui/internal/scripting/lua.go
Lines 313 to 323 in c3c1596
There was a problem hiding this comment.
Yes, I'll update this. Thanks!
099cad6 to
336e1f5
Compare

This PR adds an experimental convenience feature for users who customise
jjuiwith Lua scripts.It introduces a new CLI command,
jjui --install-lua-types, which installs a Lua type definition file into the user’s jjui config directory. That file is generated automatically from jjui’s intent metadata, so the exposed action and API surface stays in sync with the application rather than being maintained by hand.The goal is to make Lua-based customisation easier in editors that support LuaLS by providing autocomplete and basic type information while writing
config.luaand related scripts. This is intended as a lightweight quality-of-life improvement for people already using jjui’s Lua scripting support, rather than a new core workflow.