Minor fixes to custom_shader example#3319
Open
mfreeborn wants to merge 3 commits intoiced-rs:masterfrom
Open
Conversation
The `resize` method only ever checks the size upon creation. Remove the redundantly stored `size` parameter and instead use the actual size of the raw buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of minor changes and fixes.
cgmath, rather thanglam, which, in turn, usesRadandDegtypes.)Buffernever does updates its ownsizevalue upon::resize(). It looks like we can instead rely on the underlying raw buffer's::size()when determining whether the raw buffer should be recreated. The pre-existing behaviour recreates the raw buffer every frame, becausesizeis initialised to hold just one cube, and thus the condition to create a new buffer is basically always met.