⌘ + Backspace and ⌘ + Delete macOS Shortcuts in text_input#2862
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Nov 24, 2025
Merged
⌘ + Backspace and ⌘ + Delete macOS Shortcuts in text_input#2862hecrj merged 1 commit intoiced-rs:masterfrom
text_input#2862hecrj merged 1 commit intoiced-rs:masterfrom
Conversation
andymandias
force-pushed
the
text_input-command_shortcuts
branch
from
4827424 to
b522c35
Compare
…_input`. Additionally, prevent move-by-word when `text_input` is secure.
andymandias
force-pushed
the
text_input-command_shortcuts
branch
from
b522c35 to
e709fdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add support to
text_inputs for the macOS shortcuts:Edit to try to be clearer about the secondary change made in the process of adding the shortcuts:
For delete-by-word on a secure
text_input, where the word boundaries should not be exposed, the deletion was instead being made to the start/end of thetext_input. For move/select-by-word on a securetext_input, the move/selection was being made by one character. For consistency, I modified the move/select-by-word behavior for securetext_inputto match the range of movement in the delete-by-word behavior. I.e. I changed move/select-by-word behavior for a securetext_inputto move/select to the start/end of thetext_input.