Conversation
There was a problem hiding this comment.
Noticed that Select & NativeSelect are both documented within this page, so I didn't bother creating a NativeSelect.sizes.tsx.
| import { visuallyHidden } from "@mui/utils"; | ||
|
|
||
| export default () => { | ||
| const id = React.useId(); |
There was a problem hiding this comment.
You can't use the same id for both sliders.
Suggest splitting this into two components (defined below and used in the default export), each with their own id.
There was a problem hiding this comment.
Like this? 6f22da4
Should I do the same for Select.sizes.tsx?
stratakit/examples/mui/Select.sizes.tsx
Lines 14 to 17 in 6f22da4
There was a problem hiding this comment.
Yes, that seems good, although I would keep the export default () => above the other two components (I think of it as frontloading the "big picture" view).
Doing the same in Select.sizes.tsx makes sense.
There was a problem hiding this comment.
I didn't know Table supported size="small". We should validate the design and make any adjustments (e.g. row heights and paddings) in another PR.
There was a problem hiding this comment.
I swear it used to be dense instead of size for table, but I may be misremembering.
| ]; | ||
|
|
||
| return ( | ||
| <TableContainer render={<Paper />}> |
There was a problem hiding this comment.
Should we add a size picker to this example (that defaults to "small") as it is not feasible to display multiple sizes at once?
There was a problem hiding this comment.
The default size is already shown elsewhere, so we could focus this on just the small size (and rename to Table.small.tsx).
There was a problem hiding this comment.
Should the heading be renamed to ### Dense and only describe size="small"?
There was a problem hiding this comment.
Yeah, that could work. At least the wording should be adjusted to mention that the example only shows the small size.
There was a problem hiding this comment.
Renamed documentation header & code sample, updated documentation in 83ea425.
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Changes
AutocompleteButtonGroupSelectSliderTableChipcode example toChipdocumentation.Testing