Add downloading of changed element file and changed element property in get changeset links#333
Draft
Draighneys wants to merge 2 commits intomainfrom
Draft
Add downloading of changed element file and changed element property in get changeset links#333Draighneys wants to merge 2 commits intomainfrom
Draighneys wants to merge 2 commits intomainfrom
Conversation
Draighneys
changed the title
Draighneys
commented
Jan 22, 2026
| }; | ||
| } | ||
|
|
||
| private async downloadChangedElementsFile( |
Author
There was a problem hiding this comment.
I think we will need fileSize for the changed element file if we want to have a retry policy.
Draighneys
commented
Jan 22, 2026
| }; | ||
|
|
||
| let loggedError: Error | undefined; | ||
| try { |
Author
There was a problem hiding this comment.
do we want to delete the file if it exists
Contributor
There was a problem hiding this comment.
If we won't have retry then I would say yes, because existing file may be incomplete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.