Fixing content-type header being present for empty body requests#173
Open
Fixing content-type header being present for empty body requests#173
Conversation
denis-sav
requested review from
aerimagne,
amikoliunas,
austeja-bentley and
robertas-kerpys
as code owners
austeja-bentley
suggested changes
Jun 6, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| constructor(parseErrorFunc: ParseErrorFunc) { | ||
| this._parseErrorFunc = parseErrorFunc; | ||
| delete axios.defaults.headers.post["Content-Type"]; |
Contributor
There was a problem hiding this comment.
Please add a comment explaining why we are doing this. Also does this solution require to pin axios to exact version 1.1.0?
Contributor
Author
There was a problem hiding this comment.
There is a problem with transpiling axios on 1.1.3, here's an issue for further information:
axios/axios#5011
it should would work if all axios import statements would be changed to require('axios') but since it's a bug inside axios i'm not sure if it is worth to do it rather than just to change version and wait for new version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.