Exclude no internal violations from packages provided as list argument#85
Open
BeAliAslam wants to merge 2 commits intomainfrom
Open
Exclude no internal violations from packages provided as list argument#85BeAliAslam wants to merge 2 commits intomainfrom
BeAliAslam wants to merge 2 commits intomainfrom
Conversation
|
|
BeAliAslam
requested review from
anmolshres98,
aruniverse,
ben-polinsky and
paulius-valiunas
as code owners
Collaborator
|
Hi and thanks. Could you add a test(s) for this? And also run |
Contributor
|
Does this not suffice for your purposes? |
Member
|
Why is this needed? Which pkgs are you trying to exclude from the no-internals? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a flag excludeOriginPackagePatterns to no-internal rule which lets user provide a list of packages, calls originating from which are to be excluded processing for no internal rule.