detect files that don't need to be linted in no-internal#40
Draft
MichaelBelousov wants to merge 30 commits intomainfrom
Draft
detect files that don't need to be linted in no-internal#40MichaelBelousov wants to merge 30 commits intomainfrom
MichaelBelousov wants to merge 30 commits intomainfrom
Conversation
…orkspace-tools dep
Contributor
Author
|
found some issues, redrafting to fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In workspaces or general linting of large amounts of code which do not always use @itwin/@bentley packages, it is possible to avoid expensively checking every identifier by first determining whether the file is in a package with dependencies that we want to check for
@internalAPIs at all. Hide it behind an "experimental" optionIn a local project this provided me a 33% speed up in a particular build pipeline