update require-version-in-deprecation for new deprecation policy#102
Merged
paulius-valiunas merged 7 commits intomainfrom May 28, 2025
Merged
update require-version-in-deprecation for new deprecation policy#102paulius-valiunas merged 7 commits intomainfrom
paulius-valiunas merged 7 commits intomainfrom
Conversation
paulius-valiunas
requested review from
anmolshres98,
aruniverse and
ben-polinsky
as code owners
ben-polinsky
previously approved these changes
May 16, 2025
Collaborator
ben-polinsky
left a comment
ben-polinsky
left a comment
There was a problem hiding this comment.
Regex is a bit gnarly but the comprehensive tests ease my fears.
paulius-valiunas
dismissed
ben-polinsky’s stale review
significant new changes pushed
ben-polinsky
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule has multiple uses:
addVersionoption, the rule will add that version to every deprecation comment that doesn't already contain a version in the expected place.removeOldDatesoption is enabled, the rule will check the dates in deprecation comments and replace any expired ones with "might be removed in next major version".The first use is intended for developer machines and PR pipelines. The rest are intended for automating the release process.