adding subtypes of door and transportationmechanism#650
Open
adding subtypes of door and transportationmechanism#650
Conversation
| </Target> | ||
| </ECRelationshipClass> | ||
|
|
||
| <ECEntityClass typeName="Railing" displayLabel="Stair Flight" modifier="None" description="a frame assembly adjacent to circulation spaces where it is used in lieu of, or to compliment walls. An optional physical support to prevent injury or damage, either by falling or collision."> |
Contributor
There was a problem hiding this comment.
TODO: Fix displayLabel.
JValiunas
commented
Feb 3, 2026
| <Class class="RailingType"/> | ||
| </Target> | ||
| </ECRelationshipClass> | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
we need a Landing class - could be a metallic frame or timber
Collaborator
Author
There was a problem hiding this comment.
discussion led us to believe "Landing" would be spatial in nature, not part of this schema.
We need a way to associate slab with stair. consult with structural domain authors
JValiunas
commented
Feb 3, 2026
| <BaseClass>TransportationMechanism</BaseClass> | ||
| </ECEntityClass> | ||
|
|
||
| <ECEntityClass typeName="Elevator" displayLabel="Elevator" modifier="None" description="Elevator or lift to move people or goods vertically."> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft PR for some missing ArchPhys classes