Merged
Conversation
…me for Last Modified column
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds sorting functionality to iTwin and iModel grid table views, fixes date column labeling, and resolves several UI issues. The changes enable users to sort table columns while maintaining appropriate restrictions on non-sortable columns.
Key changes:
- Added sorting capability to iTwin and iModel grid tables
- Corrected column labels and data sources for date fields (Created Date vs Last Modified)
- Disabled sorting on favorite columns and simplified sorting implementation by removing manual sort handling
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/modules/imodel-browser/src/containers/iModelGrid/useIModelTableConfig.tsx | Disabled sorting on favorite column and refactored cell rendering for name and description columns |
| packages/modules/imodel-browser/src/containers/iModelGrid/IModelGrid.tsx | Renamed component from ITwinGridInternal to IModelGridInternal, simplified sort state management, updated column label from "Last Modified" to "Created Date", and removed manual sorting logic |
| packages/modules/imodel-browser/src/containers/ITwinGrid/useITwinTableConfig.tsx | Disabled sorting on favorite column and corrected Last Modified column to use lastModifiedDateTime instead of createdDateTime |
| packages/modules/imodel-browser/src/containers/ITwinGrid/ITwinGrid.tsx | Enabled sorting by adding isSortable prop and cleaned up documentation formatting |
| packages/apps/storybook/src/imodel-browser/IModelGrid.stories.tsx | Added aria-label to IconButton for accessibility |
| common/changes/@itwin/imodel-browser-react/omar-add-sorting-itwin-grid_2026-01-03-02-11.json | Added changelog entry for the patch release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…winTableConfig.tsx Co-authored-by: Copilot <[email protected]>
…ng and update column names
Contributor
|
Minor thing, but you didn't mention the table loading state (a much needed addition) in the pr description |
Contributor
Author
what was changed with the table loading state? |
simihartstein
approved these changes
Jan 16, 2026
aruniverse
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.