replace deprecated pkg_resources with importlib.resources #13
Merged
Conversation
Contributor
Author
|
tests pass locally: |
Contributor
Author
|
oh sorry I forgot to ping @hover2pi 😅 |
|
Just adding a quick note to say that the motivation behind this is the updating of the packaging and testing for Mirage, which surprisingly, still has a few users. Some solar system folks are using it to insert fake asteroids/TNOs into their data in order to measure recovery rates vs magnitude. |
Owner
|
Merged! Thanks for the fix @zacharyburnett ! |
Contributor
Author
|
great! If we can get a new release to PyPI then this will solve our dependency issue 😄 |
Owner
|
@zacharyburnett Uploaded to PyPI: https://pypi.org/project/hotsoss/0.1.11/ Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg_resourcesis deprecated and was recently removed fromsetuptools>81This change replaces usages of
pkg_resourceswithimportlib.resources(see https://importlib-resources.readthedocs.io/en/latest/migration.html)