Skip to content

fix(onetimeauth): prevent double final #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tony-go wants to merge 3 commits into from
Closed

fix(onetimeauth): prevent double final #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41b6ff1
fix(onetimeauth): prevent double final producing zero MAC
tony-go Mar 10, 2026
138b75f
fix(onetimeauth): detach state buffer after final
tony-go Mar 10, 2026
a9fefd3
fix(onetimeauth): reject update after final on detached state
tony-go Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,6 +1337,7 @@ exports.crypto_onetimeauth_init = function (state, k) {
exports.crypto_onetimeauth_update = function (state, input) {
assert(ArrayBuffer.isView(state), 'state must be a typed array')
assert(ArrayBuffer.isView(input), 'input must be a typed array')
assert(!state.buffer.detached, 'state has already been finalized')
assert(
state.byteLength === binding.crypto_onetimeauth_STATEBYTES,
"state must be 'crypto_onetimeauth_STATEBYTES' bytes"
Expand All @@ -1350,6 +1351,7 @@ exports.crypto_onetimeauth_update = function (state, input) {
exports.crypto_onetimeauth_final = function (state, out) {
assert(ArrayBuffer.isView(state), 'state must be a typed array')
assert(ArrayBuffer.isView(out), 'out must be a typed array')
assert(!state.buffer.detached, 'state has already been finalized')
assert(
state.byteLength === binding.crypto_onetimeauth_STATEBYTES,
"state must be 'crypto_onetimeauth_STATEBYTES' bytes"
Expand All @@ -1361,6 +1363,8 @@ exports.crypto_onetimeauth_final = function (state, out) {

const res = binding.crypto_onetimeauth_final(state, out)

state.buffer.transfer()

if (res !== 0) throw new Error('status: ' + res)
}

Expand Down
35 changes: 35 additions & 0 deletions test/crypto_onetimeauth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,41 @@ test('crypto_onetimeauth', function (t) {
t.ok(sodium.crypto_onetimeauth_verify(mac, value, key), 'verifies')
})

test('crypto_onetimeauth - double final must not produce zero MAC', function (t) {
const key = Buffer.alloc(sodium.crypto_onetimeauth_KEYBYTES)
const state = Buffer.alloc(sodium.crypto_onetimeauth_STATEBYTES)
const out = Buffer.alloc(sodium.crypto_onetimeauth_BYTES)

sodium.randombytes_buf(key)
sodium.crypto_onetimeauth_init(state, key)
sodium.crypto_onetimeauth_update(state, Buffer.from('hello'))
sodium.crypto_onetimeauth_final(state, out)

const validMac = Buffer.from(out)
t.not(validMac, Buffer.alloc(validMac.length), 'first final produces valid MAC')

t.exception.all(function () {
sodium.crypto_onetimeauth_final(state, out)
}, 'second final throws instead of producing zero MAC')

t.alike(out, validMac, 'MAC was not overwritten by second final')
})

test('crypto_onetimeauth - update after final must throw', function (t) {
const key = Buffer.alloc(sodium.crypto_onetimeauth_KEYBYTES)
const state = Buffer.alloc(sodium.crypto_onetimeauth_STATEBYTES)
const out = Buffer.alloc(sodium.crypto_onetimeauth_BYTES)

sodium.randombytes_buf(key)
sodium.crypto_onetimeauth_init(state, key)
sodium.crypto_onetimeauth_update(state, Buffer.from('hello'))
sodium.crypto_onetimeauth_final(state, out)

t.exception.all(function () {
sodium.crypto_onetimeauth_update(state, Buffer.from('world'))
}, 'update after final throws')
})

test('crypto_onetimeauth_state', function (t) {
const key = Buffer.alloc(sodium.crypto_onetimeauth_KEYBYTES, 'lo')
const state = Buffer.alloc(sodium.crypto_onetimeauth_STATEBYTES)
Expand Down