Skip to content

fix(memory): set secure flag properly #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tony-go merged 1 commit into from
Mar 9, 2026
Merged

fix(memory): set secure flag properly #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ exports.sodium_malloc = function (size) {
exports.sodium_free = function (buf) {
if (!buf || !buf.secure) return

buf.secure = false
binding.sodium_free(buf.buffer)
}

Expand Down
14 changes: 14 additions & 0 deletions test/memory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,20 @@ test('sodium_free, double free', function (t) {
t.ok(buf.byteLength === 0)
})

test('sodium_free should clear secure flag', function (t) {
const buf = sodium.sodium_malloc(32)

t.ok(buf.secure === true, 'buf.secure is true before free')

sodium.sodium_free(buf)

t.ok(buf.byteLength === 0, 'buffer is detached after free')
t.ok(buf.secure === false, 'buf.secure is false after free')

sodium.sodium_free(buf)
t.ok(buf.secure === false, 'second free is a no-op, secure stays false')
Comment thread
tony-go marked this conversation as resolved.
})

test.skip('sodium_malloc bounds', function (t) {
t.throws(function () {
sodium.sodium_malloc(-1)
Expand Down