Open
Conversation
The existing logic had a flaw. It assumed and stable order in the `importTree`, which was not given. Sometimes the `importer` that was used contained a query param `?` in the id, which prevented `this.resolve()` from resolving correctly.
Contributor
Author
|
Ok, need to look at the failing test... |
Contributor
Author
|
The implementation work with the
|
Contributor
Author
|
@hmsk Is there anything that needs to be done for the PR to be merged? Is this project still maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing implementation assumed a stable order in the
importTree, which is not given. Sometimes theimporterthat was used contained a query param?in the id, which preventedthis.resolve()from resolving correctly, leading to an error such the following. We combine multiple Elm apps into on big bundle to share the same Elm runtime.