fix: add timezone handling guidance to yfinance-data skill#53
Merged
Conversation
yfinance returns tz-aware datetime indices (America/New_York), but the skill had no guidance about this. Generated code would compare tz-naive Timestamps against tz-aware indices, causing: TypeError: Cannot compare tz-naive and tz-aware datetime-like objects Added timezone handling as a key rule in SKILL.md and a dedicated section with code examples in the API reference.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
America/New_York), but the skill had no guidance about this, causing generated code to crash withTypeError: Cannot compare tz-naive and tz-aware datetime-like objectsTest plan
🤖 Generated with Claude Code