[4.3] test support for partition key annotation#3262
[4.3] test support for partition key annotation#3262roguebee-droid wants to merge 2 commits intohibernate:mainfrom
Conversation
|
Why this PR contains changes to TimeStampTest? |
|
My previous issue fix is on my main branch which I branched off, want to leave that as it is till it's merged into yours rather than potentially mess up that issue. I'm going to rebase to an earlier commit and do the changes to that, then force them onto this branch. You might need to reopen this pull request again as that could auto close the pull request. Sorry about this, learning experience with github. |
dedd684 to
fb87b38
Compare
|
Thanks a lot. I don't think this test is enough, though. The problem is that I can remove the annotation and it doesn't fail. Although, in Hibernate Reactive we have a different way to check SQL queries, you can find an example here: Because the queries will use standard SQL, I think it should work on all databases even if you are testing native queries. The Hibernate ORM documentation has an example of the SQL looks like: Section 3.11.1 Partitioning |
I've added a fairly straightforward test for partition key #3108 based on what is in hibernate-orm
Hibernate-orm does have some more tests for this annotation for specific databases as well as association which I haven't done here but could add if required.