Conversation
It tried to parse as JSON, which doesn't work for a raw response. I've made the status check stricter, requiring 200. A different status risks silently accepting wrong semantics, e.g. partial response. So this is a breaking change, but that's the only sensible course of action, and I expect it to impact nobody, because I don't expect anyone to use this on files that are JSON strings. Nobody has "JSON string" files and they aren't even valid JSON files according to some definitions. So dead code seems plausible. I have changed the signature, so any (implausible) breakage won't go unnoticed at compile time.
hercules-ci-effects might be overkill for just ciSystems but ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.