option source permalinks#1581
Open
mightyiam wants to merge 3 commits intohercules-ci:mainfrom
Open
Conversation
Contributor
mightyiam
commented
Jul 2, 2025
mightyiam
commented
- move a let in
- option source permalinks
mightyiam
force-pushed
the
option-permalinks
branch
2 times, most recently
from
b46d237 to
3cc74b8
Compare
mightyiam
commented
Jul 2, 2025
Contributor
Author
|
Oh and if you review the two commits separately it's a little bit easier. |
mightyiam
force-pushed
the
option-permalinks
branch
from
3cc74b8 to
ffb4be1
Compare
roberth
reviewed
Jul 21, 2025
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
TODO later: find a way to document importable options
1 suggestion
The rest LGTM!
mightyiam
force-pushed
the
option-permalinks
branch
from
ffb4be1 to
f754906
Compare
Co-authored-by: Robert Hensing <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.