fix(agent): prevent memory/swap uint64 underflow causing unrealistic usage spikes#1978
Open
svenvg93 wants to merge 1 commit intohenrygd:mainfrom
Open
fix(agent): prevent memory/swap uint64 underflow causing unrealistic usage spikes#1978svenvg93 wants to merge 1 commit intohenrygd:mainfrom
svenvg93 wants to merge 1 commit intohenrygd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
Fix uint64 integer underflow in memory and swap stat collection that could cause anomalous spikes (millions of TB) in reported memory usage. When
/proc/meminfovalues are transiently inconsistent, gopsutil can return aUsedvalue greater thanTotal, orSharedcan exceedCached + Buffers, both of which cause unsigned integer wraparound to near-MaxUint64.fixes #1975
🪵 Changelog
🔧 Fixed
v.Used > v.Totalto prevent transient/proc/meminfoinconsistencies from producing unrealistic memory usage spikescacheBuffcalculation (Cached + Buffers - Shared) which could wrap to ~18 exabytes whenShared > Cached + Buffers; also removed the dead<= 0guard that could never trigger on a uint64SwapUsedcalculation by guarding the subtraction before performing it