Skip to content

Fixed the password manager login issue#1970

Open
Damilola-smartwork wants to merge 1 commit intohenrygd:mainfrom
Damilola-smartwork:login-fix
Open

Fixed the password manager login issue#1970
Damilola-smartwork wants to merge 1 commit intohenrygd:mainfrom
Damilola-smartwork:login-fix

Conversation

@Damilola-smartwork
Copy link
Copy Markdown

📃 Description

The login form had two problems that combined to make the button appear unresponsive when pasting credentials from a password manager.

📖 Documentation

Add a link to the PR for documentation changes.

🪵 Changelog

➕ Added

  1. Moved setIsLoading(true) to after validation passes
    The button now only enters loading state when the form is valid and an actual API call is about to be made. If validation fails for any reason, the button stays normal and an error is shown immediately.
  2. Filter out the honeypot field from errors, show a fallback message
    The error loop now skips the website field entirely. If the only thing that failed was the honeypot (meaning no visible field has an error to display), a generic message is shown on the email field — "Please check your details and try again" — so the user always gets feedback.
  3. Clean up the error handling code
    Removed the console.log debug statement
    Properly typed the errors object (Record<string, string>)
    Replaced issue.path[0].key with the null-safe issue.path?.[0].
    Removed the @ts-expect-error suppression

🔧 Fixed

  • Passport Manager login issue

Completed with assistance of Replit

@aqsede
Copy link
Copy Markdown

aqsede commented May 6, 2026

Does this fix #1011 issue with Bitwarden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants