Fixed the password manager login issue#1970
Open
Damilola-smartwork wants to merge 1 commit intohenrygd:mainfrom
Open
Fixed the password manager login issue#1970Damilola-smartwork wants to merge 1 commit intohenrygd:mainfrom
Damilola-smartwork wants to merge 1 commit intohenrygd:mainfrom
Conversation
|
Does this fix #1011 issue with Bitwarden |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
The login form had two problems that combined to make the button appear unresponsive when pasting credentials from a password manager.
📖 Documentation
Add a link to the PR for documentation changes.
🪵 Changelog
➕ Added
setIsLoading(true)to after validation passesThe button now only enters loading state when the form is valid and an actual API call is about to be made. If validation fails for any reason, the button stays normal and an error is shown immediately.
The error loop now skips the website field entirely. If the only thing that failed was the honeypot (meaning no visible field has an error to display), a generic message is shown on the email field — "Please check your details and try again" — so the user always gets feedback.
Removed the
console.log debugstatementProperly typed the errors object
(Record<string, string>)Replaced
issue.path[0].keywith thenull-safe issue.path?.[0].Removed the
@ts-expect-errorsuppression🔧 Fixed