Auto-update system host if the agent's IP has changed#1845
Open
DX-Kevin wants to merge 1 commit intohenrygd:mainfrom
Open
Auto-update system host if the agent's IP has changed#1845DX-Kevin wants to merge 1 commit intohenrygd:mainfrom
DX-Kevin wants to merge 1 commit intohenrygd:mainfrom
Conversation
Collaborator
|
Quick question: what will happen when I configured a dns name when adding the system and not a ip address? btw please remove the committed agent binary from the commit 🙂 |
|
The necessity of this modification isn't entirely clear. Furthermore, as @svenvg93 pointed out, the current implementation relies on a simple string comparison, which would forcibly overwrite the domain name configured by the user. Regarding the use case you mentioned, here are a few suggestions:
You can simply enter any placeholder IP in the frontend.
Actually, older versions did indeed have an issue where Agents would go offline when the IP changed. But I haven't encountered it at all since upgrading to the newer releases. I'd recommend trying out the latest version to see if it resolves your issue. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Auto-update system host if the agent's IP has changed
updateSystemHost checks if the current connection's IP matches the system's recorded host